1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

CKEditor 0.1

Discussion in 'Plugins' started by JonH, Sep 25, 2010.

  1. scaza

    scaza Active Member

    html_entity_decode transforms things like
    Code:
    <b>
    into
    Code:
    <b>
    I would assume it's not much of a security risk. I'm a little confused about why that would cause the black diamond problem though. I suspect the root of that is elsewhere. I haven't had to much of an issue with the diamonds. Occasional I'll submit a story and the first time I edit it I will get the diamonds but mostly it works as expected.
     
  2. seekyt

    seekyt Donor Donor

    Yep, that's what happens in the DB, but then transforming those characters back into HTML doesn't seem to happen when using CKEditor. My members don't bookmark - they only write articles. Since so many people are used to double spacing, it was very common to see more than 100 of those diamonds on a page when someone didn't "confirm" right away in step 3, or if they edited their article at a later date. Then, my member base did not want to manually delete the diamonds - they wanted a quick solution or else they would move on to another site. This was the solution that worked for me, and apparently a lot of people around the internet have this problem with text editors. Another thing that solved the problem temporarily was to change the character set from UTF-8 to iso-8859-1, but other errors occurred with this. So, getting rid of the core problem was the best bet for my site.

    I'm glad to know that you don't think this will cause any issues.
     
  3. scaza

    scaza Active Member

    I'm by no means an security expert so don't take my word for it, I just don't know why it would be a problem.
    So you're are still encoding their posts with html entities but just not decoding it on display?

    Now that you mention it the double space thing is exactly what gives me the problems too.
    Since the problematic character sequence is very specific it might be best to just convert all double spaces to single space on submit or find where they get added in the first place and remove them.
     
  4. WimTibackx

    WimTibackx New Member

    Patch to be more generally applicable

    Hello everyone,

    I needed CkEditor in a plugin of mine, but I saw that this plugin wasn't very generally applicable. So I patched it :). I took the opportunity to bump up the CkEditor version to 3.5.2 (16th of February 2011). At the same time, backwards compatability with the submit plugin is maintained.

    View attachment ckeditor-0-2.zip
     
    JonH and seekyt like this.
  5. scaza

    scaza Active Member

    Thanks WimTibackx. But I'm unclear what you mean by patched it. Can you clarify what you changed? Maybe add it to the changelog in the readme.txt file.

    @ seekyt Aside from the double space accented characters are also lost when editing stories.
     
  6. seekyt

    seekyt Donor Donor


    After I made the aforementioned changes to submit.php, I am not having any problems with character encoding anymore, including accented characters, double spaces, and double page breaks.
     
  7. WimTibackx

    WimTibackx New Member

    Sorry, I should indeed have done that. What I changed:
    • You can now use any textarea-id dynamically
    • It can now also work in the admin interface (where it only supported frontend before)
    • You can still use it like before, with the submit plugin, and it works, so backwards compat with Submit
    • I put in a newer version of CkEditor itself

    Hope that clarifies things.
     
  8. iKnockz

    iKnockz New Member

    JonH likes this.
  9. JonH

    JonH Admin & Design

    Thanks iKnockz. If you open it up and look at it you'll see it was pretty simple, ( I do a lot of paste and prey coding and ask a lot of questions lol) It shows how easy Hotaru plugins are! WimTib, I don't have a Hotaru site or the time to check out your patch, but thanks for the update.
     
  10. theak87

    theak87 Active Member

    We are unable to see the embed video in the post page.How do we do that???
    Allowed HTML tags: <h1><h2><h3><h4><h5><iframe><h6><pre><div><ol><li><address><img><b><i><u><a><blockquote><strike><u><em><strong><span><a><a><s><hr><embed><object><youtube>
    But unable to view when submitted.
    As we can see in http://lawrkhawm.com/
    it seems that they are not using media select and video inc plugin while submit.
    We can embed any video and it displays in preview page as well as in post page.
    Plz let me know how we do that???
    thnx.
     
    Last edited: Mar 25, 2011
  11. scaza

    scaza Active Member

    embed tags can't be allowed. Try the oembed or similar plugin.
     
  12. theak87

    theak87 Active Member

    thnx for the suggestion but even oembed 0.3 is not working.I have already tested with this plugin too.
     
  13. hieptran258

    hieptran258 New Member

    Appreciate! This plug in is what i've been looking for.
     
  14. hotaruuser

    hotaruuser New Member

    Hi there!

    CKEditor is now on version 3.6.1, I would like to upgrade. Its just overwriting the old files in the javascript folder from the plugin?

    And I wanted to configure the editor, because of the safetyfunctions of hotaru, all buttons do not work. (For example, if I add a list, it is not saved in the database, I think this is wished so?) Has anybody worked on this before? Any tipps would be great
     
  15. scaza

    scaza Active Member

    ckeditor has easy to follow documentation on how to remove buttons. Not sure why lists don't work when other tags do once you add them to the 'allowable html tags' box. Seems to me like they would be pretty harmless.
     
  16. hotaruuser

    hotaruuser New Member

    Thank you for your reply! The upgrade was no problem, just remember not to override the config.js file in the javascript folder! I removed the list buttons, not needed them anyway. It is really good documented!
     
  17. valMETNG

    valMETNG Administrator Staff Member Admin

    Character encoding hell

    That's where I've been for the last many hours. I was seeing the dreaded black diamond with a question mark whenever there was an extra blank line in post content. I wasn't able to determine where the problem is originating from, nor do I understand why this fixes it, but it does. So, if you get the nasty ?, remove html_entity_decode from line 574 in /plugins/submit/submit.php so that it looks like:
    Code:
    $h->vars['submit_content'] = $h->vars['submit_content'];
    It still adds an extra space at the end (which trim doesn't seem to remove, so maybe there's still some hidden character there), but at least it gets rid of the ?.
     
    nothingman likes this.
  18. nothingman

    nothingman Active Member

    I have existing posts that have this diamond ? character, but this didn't remove it. Or is this supposed to work for new posts? :confused:
     
  19. valMETNG

    valMETNG Administrator Staff Member Admin

    Sadly, this would only work for newly submitted posts.
     
    nothingman likes this.
  20. nothingman

    nothingman Active Member

    Thanks valMETNG, that's not a problem.
     

Share This Page