1.7 Php7 Warnings And Errors

I recently did a quick test of just-released PHP7 in my build and immediately noticed the following warnings:

The issue occurs because PHP7 will deprecate PHP4 Style constructors. The Inspect library hasn't been maintained in about 6 years but it would be quite the chore to remove it from Hotaru core given it's used pretty much everywhere (and I'm not sure what a better library would be). @shibuya246, what do you think is the best way to approach this? Here are some ideas from WordPress.

For those who are testing PHP7, please post any warnings or errors you see in this thread. Auditing the code is going to take some time and effort.

 

So far, the above warnings are the only ones I've found. To remove these warnings, I've made the following changes:

Change line 21 in /libs/extensions/Inspekt/Inspekt/Error.php, line 61 in /libs/extensions/Inspekt/Inspekt/Cage.php, line 77 in /libs/extensions/Inspekt/Inspekt/Supercage.php, and line 61 in /libs/extensions/ezSQL/ez_sql_core.php to:

Code:

function __construct() {

Change line 48 in /libs/extensions/ezSQL/mysqli/ez_sql_mysqli.php to:

Code:

function __construct($dbuser='', $dbpassword='', $dbname='', $dbhost='localhost', $encoding='')

You will also need to either change your PHP environment (e.g., under cPanel PHP Selector) to 7.x or add the following line to the top of your .htaccess:

Code:

AddHandler application/x-httpd-php70 .php .php5 .php4 .php3

Oh yes. It is indeed MUCH faster. Based on some random testing, I'm seeing about 45-50% increases in page load time.

 

Interesting - what did you do to generate this error? I submitted links both with a domain found and a non-existing domain and neither generated this error. I want to know this as there might be testing I'm missing.

To fix -

Change line 51 in /vendor/phpwhois/phpwhois/src/whois.main.php and line 71 in /vendor/phpwhois/phpwhois/src/whois.client.php to:

Code:

function __construct()

Change line 94 of /vendor/phpwhois/phpwhois/src/whois.idna.php to:

Code:

function __construct($options = false)

For the last one, I gave you the fix above for ez_sql_core.php - did you forget to change?

 

I'm glad it works. But what did you do previously to generate the error?

 

@narc found another one in libs/extensions/GenericPHPConfig/class.metadata.php. (Shows how awful my testing was.) To fix, change line 79 to:

Code:

function __construct() {

 

Internal server errors are sometimes difficult to figure out. For me, I almost always find the problem is related to a mistake in the .htaccess file.

 

Never mind - I figured it out.

 

I'm waiting for my host to get it through testing and offer it

 

I thought you said earlier you were able to get it working on local? Now it's not working?

I know how hard it is to troubleshoot environment errors. If you have the local environment configuration files when it was working, you could compare those to the ones you have now (or the ones on your live site). Be sure to look at both your server configuration files and your php.ini file. Another place to look is to compare the environment settings from your earlier PHP 5.x environment to the PHP 7.x environment. There may be a setting difference. Also, it could be a file or directory needs to have different permissions (e.g., using chmod, change all files and directories in your test environment to 777 - if you don't see the 500 error anymore, then it's a permissions issue).

I've never used it but, while searching for other ideas, I came across PHP7 compatibility checker. Perhaps you could try this to see what issues it finds.

 

It's unclear if this is related to using PHP 7, but I think it is. I'm seeing the following errors in 1.7.3 base:

To fix it, replace line 88 with:

Code:

$parts1 = (string)$parts[1];
$cron_call->$parts1($h);

 

My hosting provider upgraded PHP7 to PHP7.0.7 recently without telling anyone and it caused my site to crash. For any of you using PHP 7, I wanted to post the fix so you don't spend 2 full days figuring it out as I just did

There was a harmless PHP bug (69659 according to PHP's change log - see also 72117) corrected in the 7.0.6 patch that now "completely breaks the null-coalesce operator in PHP 7." To fix it, you'll need to replace line 163 in Hotaru.php and line 204 in /libs/Initialize.php with the following:

Code:

if (method_exists($this, 'get_' . $name) || isset($this->$name)) { return true; } else { return false; } 

From what I can tell, you should be able to make that change even if you are using an earlier PHP version.

@shibuya246, it would be great if you can review my fix and confirm it makes sense. If so, you'll want to add this to the queue for future releases.

 

Sure. In Hotaru.php, starting on line 160, the full function looks like this:

Code:

        // to get protected properties
        public function __isset($name)
        {
                return isset($this->data[$name]);
        }

In /libs/Initialize.php, starting on line 200, the line looks like this:

Code:

        // to get protected properties
        public function __isset($name)
        {
                //echo "Is '$name' set?\n";
                return isset($this->data[$name]);
        }

So you're replacing the lines that start with "return."

Effectively, when using > PHP 7.0.6, Hotaru's isset() functions stop working on array dimensions. The first thing to go were the plugins: none of them would get loaded because there are functions that go and grab all the functions and put them into arrays. After doing this, Hotaru checks if the plugin arrays are empty and, if they are, it leaves you with an "oops" page not found. However, the arrays were not empty - they were just evaluated as empty because of the bug.

 

I have gone through and fixed a number of issues related to the latest version of php7. one of the main ones is that the mysql extensions are not longer bundled with php7 as they were back in 5. I had previously added code for the mysqli extensions so the switch is easy. I will change these in addition to the points above and put out a new release. If you want to check specific things that have changed let me know.

PHP:

return isset($this->data[$name]);

I decided to get around the null-coalesce operator using this so that it is backward compatible as well

PHP:

    $thisData = $this->data;
    $item = $thisData[$name];
    return isset($item);


not pretty, but it does the job