Submit 3.5

When I see the word "Share" on blogs I normally think they mean I can take that content and share it somewhere else.
When I see the word "Submit", I normally think I am putting something onto the site before me.

So for a Hotaru CMS site, submit seems more logical than share, but an alternative to submit is still worth thinking about if you feel the word submit is not relevant. I think "Share" is already linked in many peoples mind to sending content away from a site rather than into it, like the sharethis button

http://sharethis.com/

 

Updated

updated to add an id tag on the submit forms and to catch up with other 3 versions that didnt get posted here

 

Oh, that's very nice. Very nice indeed. Thanx for sharing.

 

Regarding draft mode, there is a setting in plugin management to "Put all new posts in the moderation queue." I've never used that option, but I assume that's what it does. As to the auto save feature, if you incorporate ckeditor, ckeditor does have a plugin that has an auto save feature. It can be a bit annoying sometimes, but it does work.

 

Came across an interesting issue today with submitting a URL from a page like http://www.tagesanzeiger.ch/ausland/europa/More-punk-less-hell/story/10069405. The site's HTML is a bit messed up and the submitted_date['submit_title'] variable brought in the corrupted data, which then prevented submitting the URL. To catch this, I added the following at line 169 (after $h->vars['submitted_data']['submit_title'] = $title) in SubmitFunctions.php:

Code:

$title = substr($title, 0, stripos($title, '</title>') + 8);

This cuts off anything that comes after the title (</title>), including the tag, just in case there's a problem with the page.

Edit: I actually just realized this might be just specific to my implementation (read: massive amounts of customization), so this might not be an issue for a base build. You can use that link to determine if it's an issue.

 

I'm not 100% certain, but I believe if you remove the following code from plugins/submit/javascript/submit.js (or delete the file entirely), the field will default to a plain textarea and not use summernote:

Code:

jQuery('document').ready(function(){   
  $('#post_content').summernote({
  height: 300
  });
});

 

@Sv9t just found a somewhat complicated bug that occurs when the submit title has a backslash in it. In further testing, I found I can create this same error when submit content also has a backslash. For example, the text:

...will generate the error.

When either is saved via function saveSubmitData and then loaded via loadSubmitData, you receive an error similar to:

I'm quite embarrassed to admit how long it took to find an acceptable resolution, but it's not really a complete solution because Hotaru uses stripslashes in many places for post title and post content (which automatically removes any backslashes).

Out of all the alternatives I evaluated, this is probably the simplest. To prevent the unserialize/offset error, in /content/plugins/submit/libs/SubmitFunctions.php, replace line 273 with:

Code:

foreach ($h->vars['submitted_data'] as $key => $data) { $h->vars['submitted_data'][$key] = urlencode($data); }

...and replace line 301 with:

Code:

  if ($submitted_data)
       {
         $data_array = array();
         $encoded_data = unserialize($submitted_data);

         foreach ($encoded_data as $key => $data)
         { $data_array[$key] = urldecode($data); }

         return $data_array;
       } else { return array(); }

However, Hotaru will still strip the backslashes when displaying the content (even though it will be saved correctly) and we'd need to make many more modifications to correct that behavior (e.g., instead of using stripslashes in /libs/Post.php, we'd probably want to use something like this). A quick search of Hotaru base indicated 66 uses of stripslashes, but I don't think all of them would need to change.

@Sv9t (or @sereban), is it common in Cyrillic to use \ in text?

 

Actually, this might not work either because, after I submit the post (which it takes), I can't click on the URL because it seems $h->post->url is being encoded twice before being saved to the database (although I'm not sure why yet or where this is happening). @Sv9t, can you please test and confirm?