1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Submit 3.5

Discussion in 'Plugins' started by Nick, Aug 1, 2009.

  1. Sv9t

    Sv9t Active Member

    I replace line 273 and 301. replaced the code highlighted in blue in the screenshot.
    Now i can add 2 links on the site. valMETNG, i send PM, looking test site.
     

    Attached Files:

  2. valMETNG

    valMETNG Administrator Staff Member Admin

    According to @Sv9t's test site, it appears this fix works.
     
    Sv9t likes this.
  3. valMETNG

    valMETNG Administrator Staff Member Admin

    For you @sereban, the first change should be made on line 271 (instead of 273) and the second change should be made on line 299 (instead of line 301).
     
  4. valMETNG

    valMETNG Administrator Staff Member Admin

    So is it OK to leave it as is, or do you need the backslash \ to show up? Because, right now, even though the fix stores the backslash, Hotaru is stripping it out before displaying it. If Cyrillic uses the backslash, then Hotaru shouldn't be stripping it. (Hotaru probably shouldn't be stripping it anyway but it's done to help prevent code injections.)
     
  5. Sv9t

    Sv9t Active Member

    Cyrillic doesn't use backslash because I used "\" instead of "or" (for example, blogger \ blogspot). that's why the best solution is to leave fix and to leave it as it is. If I take away the fixes my links won't be added.
     
  6. shibuya246

    shibuya246 Hotaru Developer Staff Member Admin

    I think n written language might be more common to use a forward slash "/" for or rather than a back slash "\" ? or in coding a pipe "|" is used
    back slashes with urls should not really be mixed
     
  7. valMETNG

    valMETNG Administrator Staff Member Admin

    Yes, but Hotaru probably shouldn't be stripping characters that aren't harmful. For example, even with my suggested fixes above, you can't enter ¯\_(ツ)_/¯ in the title or description without it being modified to ¯_(ツ)_/¯. That's probably not a huge issue, but it's still an unnecessary limitation. However, the only way to rectify that is to re-evaluate the way stripslashes is applied and content cleaned.
     
  8. Sv9t

    Sv9t Active Member

    I think that it would be better if Hotaru doesn't hide backslashes but to change them on right ones and to do like this with other not standard symbols. For example WordPress works in this way, it changes "\" on "/".

    I changed backslash in title and added links on the site (changed file SubmitFunctions.php i replaced with original file). But if somebody can't change backslahes, links can't be added on the site.
    In any case, i save fix valMETNG as temporary solution of the problem.
     
    Last edited: Jun 16, 2015
  9. operan

    operan New Member

    Hello all, i can't save the settings for submit plugin from admin. Whenever i've submit on the save button it show as saved but noting change. Does anyone knows how to fix it? Thanks.
     
  10. valMETNG

    valMETNG Administrator Staff Member Admin

    I just checked my base build and was able to save the settings, so a few questions: 1) did you modify anything in the submit plugin? 2) in your error_log (which you can access in the Debug tab within the admin Maintenance button), are there any errors in there? If so, please post them here.
     
  11. operan

    operan New Member

    Hello @valMETNG thanks for your response. I did not change anything in submit plugin.

    In Submit plugin page there is an blue attention buble as : No version information could be found on the plugin server

    Here are the logs:
    [02-Jul-2015 12:48:02 Europe/Berlin] PHP Notice: Undefined index: submit_settings_category_submit_desc in /Applications/MAMP/htdocs/paylas/content/plugins/submit/submit_settings.php on line 92
    [02-Jul-2015 12:48:17 Europe/Berlin] PHP Notice: Undefined variable: redirect in /Applications/MAMP/htdocs/paylas/content/plugins/submit/submit.php on line 244
     
  12. valMETNG

    valMETNG Administrator Staff Member Admin

    Well, something is definitely wrong because I don't see the word "submit_settings_category_submit_desc" anywhere in the codebase and there shouldn't be a redirect variable on line 244. What version of the submit plugin are you using? Can you please download the most current full build and copy over the latest version of submit (and then try again)?
     
  13. operan

    operan New Member

    It shows as 3.6
     
  14. valMETNG

    valMETNG Administrator Staff Member Admin

    Odd. I just downloaded the current full build and verified those references aren't in (or shouldn't be in) submit 3.6. So I'd suggest downloading and reinstalling submit.
     
  15. operan

    operan New Member

    Yes i did 3 times. Won't work.. Is the current version 3.6 ? Thanks a lot for your help once again.
     
  16. valMETNG

    valMETNG Administrator Staff Member Admin

    You downloaded from the link I provided? And you are still seeing the same errors in your error_log when you try to save? If you are, you can PM your credentials and I can take a look on your server to see what the problem is.
     
  17. operan

    operan New Member

    Yes, i've downloaded exactly the same file. Uninstalled the old plugin - Deleted the old files and resubmitted the new one which you've provided above. But still wont save. All the rest plugins settings are ok with saving in stead submit.
     
  18. operan

    operan New Member

    Attached is the error_log file. Even not changed anything in plugin/php file it shows couple of messages.
     

    Attached Files:

  19. valMETNG

    valMETNG Administrator Staff Member Admin

    Just to finalize for anyone who might have these problems, the plugin was saving and working properly. However, the field "Allowed HTML tags in post description" must not be blank - otherwise, it will default back.
     
    shibuya246 likes this.
  20. operan

    operan New Member

    I really would like to thanks a lot for @valMETNG for his kind help and finding the right solution.

    So the system does not allow us to delete all html tags from the post description settings ( submit plugin settings ). Once we leave only one tag its saved successfully.
     
    Last edited: Jul 2, 2015
    shibuya246 and valMETNG like this.

Share This Page